Skip to content

Update the docs for the fixes to issues #63 to #94 - #112

Merged
ipjohnson merged 2 commits into
docs-ste-rewritefrom
docs/remove-fixed-warnings
Sep 24, 2026
Merged

ipjohnson merged 2 commits into
docs-ste-rewritefrom
docs/remove-fixed-warnings

Conversation

@ipjohnson

Copy link
Copy Markdown
Owner

The pages on docs-ste-rewrite now describe the behavior after the fix PRs. The warnings and limits that described the defects are removed or corrected. All changed text is in ASD-STE100.

This PR assumes that the open fix PRs #104 to #111 merge as they are. PRs #95 to #103 are already on main.

Changes per issue

For the reviewer

Verified

  • npm ci and npm run build in website/: the build completes, so there is no dead link.
  • A script check of the added lines: no semicolons, no contractions, and no sentence longer than 25 words. The only -ing words are "warning" and "missing", which the pages already use.
  • I compared each change with the PR descriptions and, for DM0023 to DM0025 and the Intercept only the registration the intercepted class makes #108 filter, with the code on the PR branches.

🤖 Generated with Claude Code

Ian Johnson and others added 2 commits September 24, 2026 08:07
The warnings and limits that described the defects are removed or corrected, and the pages now
describe the behavior of PRs #95 to #111. DM0023, DM0024 and DM0025 get entries in the
diagnostics reference. The package description of DependencyModules.SourceGenerator.Impl no
longer tells the reader to add CSharpAuthor.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…re DM0022

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@ipjohnson

Copy link
Copy Markdown
Owner Author

I added a commit, 7dcfe2a, for the change I made to #108. The factories that GenerateFactories writes are now typed to return their class. So [Decorator(Implementation = ...)] wraps exactly the class it names in a module with generated factories, and DM0022 is removed. The commit updates "Decorate one implementation" in decorators.md, the generated factories note in aot.md, and the DM0022 row and section in diagnostics.md. The DM0022 section stays, so old links still work, and it says that the generator no longer gives the diagnostic. npm run build passes.

@ipjohnson
ipjohnson merged commit fd608f1 into docs-ste-rewrite Sep 24, 2026
ipjohnson added a commit that referenced this pull request Sep 24, 2026
…113)

* Rewrite the README and documentation in Simplified Technical English

The new text follows ASD-STE100 Issue 9. It was written from the source
code, not from the previous documentation. All C# samples compile, and
the samples that can run were run. A separate review checked each claim
against the source.

This removes the pages guide/scanning, guide/testing-registrations,
reference/conventions-api, and reference/interfaces. It adds
guide/testing-container-source and reference/api. The nine package
descriptions are also rewritten.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Point .git-blame-ignore-revs at the CSharpier commit on main

79a2881 is not in the history of main. The squash merge of #62 made
d7a1a82, which is the reformat commit on main. With the old hash,
git blame still gave 53 lines of ModuleEnvironment.cs to the reformat.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Update the docs for the fixes to issues #63 to #94 (#112)

* Update the docs for the fixes to issues #63 to #94

The warnings and limits that described the defects are removed or corrected, and the pages now
describe the behavior of PRs #95 to #111. DM0023, DM0024 and DM0025 get entries in the
diagnostics reference. The package description of DependencyModules.SourceGenerator.Impl no
longer tells the reader to add CSharpAuthor.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Describe Implementation decorators with generated factories, and retire DM0022

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Ian Johnson <ianjohnson@mac.mynetworksettings.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Document three service registration limits found during the fixes

A keyed factory method, TryEnumerable for a registration whose implementation is its service
type, and a class with only internal constructors all fail at run time with no diagnostic. No
issue tracks them yet.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Restore the CSharpAuthor packing in DependencyModules.SourceGenerator.Impl

The merge of main took this branch's whole project file to keep its description, which
dropped what #103 added: GeneratePathProperty on CSharpAuthor and the items that pack its
sources. The project file now matches main except for the description.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Ian Johnson <ianjohnson@mac.mynetworksettings.com>
Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant