Skip to content

fix(ipns): surface publish errors to user#2493

Open
lidel wants to merge 1 commit into
mainfrom
fix/ipns-publish-error-feedback
Open

fix(ipns): surface publish errors to user#2493
lidel wants to merge 1 commit into
mainfrom
fix/ipns-publish-error-feedback

Conversation

@lidel

@lidel lidel commented Jun 30, 2026

Copy link
Copy Markdown
Member

Publishing to IPNS failed silently: the modal stayed on a finished-looking progress bar and the RPC error was never shown, so the operation looked stuck with no way forward.

  • ipns.js: catch name.publish failures, emit a notify toast carrying the original error, and re-throw so the modal can react
  • notify: render IPNS_PUBLISH_FAILED as an error toast using the ipnsPublishFailReason message
  • PublishModal: reset the progress state on failure so the inline error renders and Publish re-enables for a retry

Closes #2492 reported by @ilyaigpetrov

Publishing to IPNS failed silently: the modal stayed on a
finished-looking progress bar and the RPC error was never shown, so
the operation looked stuck with no way forward.

- ipns.js: catch name.publish failures, emit a notify toast carrying
  the original error, and re-throw so the modal can react
- notify: render IPNS_PUBLISH_FAILED as an error toast using the
  ipnsPublishFailReason message
- PublishModal: reset the progress state on failure so the inline
  error renders and Publish re-enables for a retry

Closes #2492
@lidel lidel requested a review from a team as a code owner June 30, 2026 00:10
@hiSandog

Copy link
Copy Markdown

This fix matches the reported UX problem well. One edge case worth covering in the test is the retry path after a failed publish: fail name.publish, assert the inline error/toast appears and the progress state resets, then trigger Publish again and verify the modal can proceed instead of staying in a terminal failed/progress state. That would protect the "Publish re-enables for a retry" behavior described in the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Publishing a File to IPNS Hangs after Throwing Internal Server Error 500

2 participants