fix(ipns): surface publish errors to user#2493
Open
lidel wants to merge 1 commit into
Open
Conversation
Publishing to IPNS failed silently: the modal stayed on a finished-looking progress bar and the RPC error was never shown, so the operation looked stuck with no way forward. - ipns.js: catch name.publish failures, emit a notify toast carrying the original error, and re-throw so the modal can react - notify: render IPNS_PUBLISH_FAILED as an error toast using the ipnsPublishFailReason message - PublishModal: reset the progress state on failure so the inline error renders and Publish re-enables for a retry Closes #2492
|
This fix matches the reported UX problem well. One edge case worth covering in the test is the retry path after a failed publish: fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publishing to IPNS failed silently: the modal stayed on a finished-looking progress bar and the RPC error was never shown, so the operation looked stuck with no way forward.
Closes #2492 reported by @ilyaigpetrov