Skip to content

chore: fixing link in readme #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pfed-prog wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: fixing link in readme #1820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cc3cc6f
fixing link in readme
Pfed-prog Jun 20, 2025
95f55c9
removed Unused '@ts-expect-error' directive
Pfed-prog Jun 22, 2025
1c3ac65
removed irrelevant old comment on eslint upgrade
Pfed-prog Jun 22, 2025
3d9b3d5
removed unused variables in lint
Pfed-prog Jun 22, 2025
0a58133
removed unused variables in dependy-check
Pfed-prog Jun 22, 2025
2ef70fc
Merge branch 'main' into main
Pfed-prog Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ It bundles config for standard tools such as eslint, mocha, etc and lets you con
}
```

You can find the complete default config [here](https://github.com/ipfs/aegir/blob/main/src/config/user.js#L12) and the types [here](https://github.com/ipfs/aegir/blob/main/src/types.d.ts).
You can find the complete default config [here](https://github.com/ipfs/aegir/blob/main/src/config/user.js#L12) and the types [here](https://github.com/ipfs/aegir/blob/main/src/types.ts).

## Continuous Integration

Expand Down
4 changes: 0 additions & 4 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,6 @@ setParser('neostandard/ts', eslintParser, {
ecmaVersion: 'latest'
})

// TODO: not compatible with ESLint 9x yet
// addPlugin('neostandard/ts', 'etc', etc)
// addRule('neostandard/ts', 'etc/prefer-interface', 'error') // https://ncjamieson.com/prefer-interfaces/

addRule('neostandard/ts', 'no-return-await', 'off') // disable this rule to use @typescript-eslint/return-await instead
addRule('neostandard/ts', '@typescript-eslint/no-use-before-define', [
'error', {
Expand Down
3 changes: 1 addition & 2 deletions src/dependency-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,8 @@ const tasks = new Listr(
title: 'dependency-check',
/**
* @param {GlobalOptions & DependencyCheckOptions} ctx
* @param {Task} task
*/
task: async (ctx, task) => {
task: async (ctx) => {
let missingOrUnusedPresent = false

// check production dependencies
Expand Down
8 changes: 2 additions & 6 deletions src/lint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ const tasks = new Listr(
/**
*
* @param {GlobalOptions & LintOptions} ctx
* @param {Task} task
*/
task: async (ctx, task) => {
task: async (ctx) => {
const eslint = new ESLint({
fix: ctx.fix,
overrideConfigFile: fromAegir('eslint.config.js')
Expand Down Expand Up @@ -64,10 +63,7 @@ const tasks = new Listr(
},
{
title: 'tsc',
/**
* @param {GlobalOptions & LintOptions} ctx
*/
enabled: ctx => hasTsconfig && !isTypescript,
enabled: () => hasTsconfig && !isTypescript,
/**
* @param {GlobalOptions & LintOptions} ctx
* @param {Task} task
Expand Down