fix(plugins): restore space separators corrupted to NUL bytes in PluginHost#198
Open
rotecodefraktion wants to merge 1 commit into
Open
Conversation
…inHost
Two byte positions in PluginHost.ts held a NUL (0x00) where a space was
intended — the coalescing-buffer key template `${event} ${target}` and its
matching doc comment. The stray NULs made git treat the whole file as
binary, so any diff touching it renders as "Binary file" and is
unreviewable. Replace both with the intended ASCII space; no behavioral
change (the key separator is now a space instead of NUL).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6 tasks
Author
|
Merge-order note: please merge this PR (#198) before #199. #198 strips two stray (Heads-up: CI shows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two byte positions in
src/plugins/PluginHost.tsheld aNUL(0x00)where an ASCII space was intended:
`${event} ${target}`(code, ~line 520)Both NULs are replaced with the intended space. That is the only
change — verified:
dev's file withNUL→spaceapplied is byte-identicalto this branch's file.
Why
The stray NUL bytes make git classify the whole file as binary, so
any PR touching
PluginHost.tsrenders as "Binary file not shown" andbecomes unreviewable. (This PR itself shows as a binary diff for exactly
that reason — the old side is the binary one.) Removing them restores
normal text diffs and fixes the buffer key separator to the intended space.
How it was tested
npm run lintnpm run typecheck(clean)npm test—plugins/permissions,pluginHost: 23 passnpm run build(verified on sibling branch off samedevbase)Notes
No behavioral change: the coalescing key separator is now a space instead
of a NUL. A follow-up PR (
fix(plugins): seed permission revocations before worker boot) builds on this so itsPluginHost.tsdiff isreviewable as text.