fix(editor): per-view ordered-list renumber guard#196
Open
rotecodefraktion wants to merge 1 commit into
Open
Conversation
The renumberInFlight guard was a module-level boolean shared by every editor instance, so in a split-pane layout one pane's in-flight renumber could suppress another pane's, leaving the second list mis-numbered. Key the flag on the EditorView via a WeakMap instead. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The
renumberInFlightguard was a module-level boolean shared by everyeditor instance, so in a split-pane layout one pane's in-flight renumber
could suppress another pane's, leaving the second list mis-numbered. The
flag is now keyed on the
EditorViewvia aWeakMap.Why
Split-pane editing of ordered lists could leave a list mis-numbered.
How it was tested
npm run lintnpm run typecheck(clean)npm test—editorKeymapCommands,listTransforms,continueListItemParagraph,taskListItem: 101 passnpm run buildNotes
Single-file change (
src/components/editor/CodeMirrorEditor.tsx).Companion PR:
perf(editor): cut redundant doc serialization in ordered-list renumberbuilds on this area.