fix(security): add origin allow-list check to zipball proxy route#193
Open
rotecodefraktion wants to merge 1 commit into
Open
fix(security): add origin allow-list check to zipball proxy route#193rotecodefraktion wants to merge 1 commit into
rotecodefraktion wants to merge 1 commit into
Conversation
The zipball route was the only GitHub proxy route without the isOriginAllowed() same-origin guard, letting any cross-origin page use the proxy as an egress amplifier for multi-MB repo archives. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Added the existing
isOriginAllowed()same-origin guard to the zipballproxy route (
src/app/api/github/zipball/route.ts), returning403fordisallowed origins before any work is done.
Why
The zipball route was the only GitHub proxy route without this guard
(every other route under
src/app/api/already usesisOriginAllowed).Without it, any cross-origin page could use the proxy as an egress
amplifier for multi-MB repo archives.
How it was tested
npm run lintnpm run typecheck(clean)npm test—originAllowlist,githubSyncZipball,zipballRetry,gitProxyOptions: 17 passnpm run buildNotes
Single-file change. Reuses the already-established
@/utils/originAllowlisthelper.