Skip to content

perf(editor): stop blocking full-doc parse on note open #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thetechjon merged 1 commit into from
Jun 15, 2026
Merged

perf(editor): stop blocking full-doc parse on note open #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/components/editor/foldableHeadings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
foldGutter,
codeFolding,
syntaxTree,
ensureSyntaxTree,
} from '@codemirror/language'
import type { EditorState } from '@codemirror/state'
import type { Tree } from '@lezer/common'
Expand Down Expand Up @@ -45,10 +44,11 @@ interface HeadingInfo {
const headingCache = new WeakMap<Tree, HeadingInfo[]>()

function resolveTree(state: EditorState): Tree {
// Force a full parse so folding works for the whole document (and in headless
// test states with no view driving incremental parsing). Falls back to the
// partial tree if the parse times out on a very large doc.
return ensureSyntaxTree(state, state.doc.length, 5000) ?? syntaxTree(state)
// Use the non-blocking parsed tree (same as the other live-preview
// extensions). The fold gutter only queries visible lines, so a forced
// full-document parse on every per-note editor remount is unnecessary and
// caused a ~1s stall on each note switch.
return syntaxTree(state)
}

function collectHeadings(state: EditorState): HeadingInfo[] {
Expand Down
Loading