feat: re-land get_batch command with bugfix#432
Open
thinkingfish wants to merge 2 commits intomainfrom
Open
Conversation
… get_batch handler Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
thinkingfish
force-pushed
the
reapply-pr-418
branch
from
15b454a to
6e3e8da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
latency_histograms.push()did not exist in scope — replaced withextra_histogram = Some(&KVGETBATCH_RESPONSE_LATENCY)to match the pattern used by Get/Set handlersContext
#418 was reverted in d8cc1b0 due to the latency histogram bug. This PR cherry-picks the original commit and applies the fix.
Test plan
cargo buildsucceedsextra_histogram🤖 Generated with Claude Code