Remove unused test deps & add AGENTS.md#9
Draft
lefi7z wants to merge 2 commits into
Draft
Conversation
Co-authored-by: lefi7z <lefi7z@users.noreply.github.com>
Both packages had zero imports anywhere in the codebase. Removing them also drops 5 transitive dependencies (docker, python-dotenv, setuptools, typing-extensions, wrapt). Co-authored-by: lefi7z <lefi7z@users.noreply.github.com>
cursor
Bot
changed the title
Member
Author
|
Yes, we should definitely provide some insightful testdata! Some interesting, but small .h5 files, some peaktables, ... just something to get to work with. (and to let the tests run!!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Removed unused test dependencies from
pyproject.toml:testcontainers ^4.13.0— zero imports in codebase; required Docker for no reasonpytest-dependency ^0.6.1— zero imports in codebase; no@pytest.mark.dependencyusage anywhereThis also drops 5 transitive dependencies:
docker,python-dotenv,setuptools,typing-extensions,wrapt.Added
AGENTS.mdwith Cursor Cloud development instructions.Dependency audit
All remaining dependencies were verified as actively used:
ionitof_reader.py,peaktable.py— HDF5 I/Oplotting.py, examples — plottingssevent.py,ioniclient.py,db_api.py— HTTP/SSE clientsionitof_reader.py,peaktable.py,mqtt.py,batch.py— DataFramesmodbus.py— Modbus TCP clientmqttclient.py,ionimock.py— MQTT instrument interface_cli.py—ionimockCLI entry pointipykernelis the only remaining candidate for removal — it has no imports or notebooks in the repo but is a reasonable dev convenience for interactive exploration.Verification
All 34 tests pass, 1 skipped (unchanged from before):