Skip to content

Fixes#151. Added the panscroll the the page. - #182

Open
Siddhartha20242 wants to merge 5 commits into
ioflux-org:mainfrom
Siddhartha20242:scroll-panscroll
Open

Siddhartha20242 wants to merge 5 commits into
ioflux-org:mainfrom
Siddhartha20242:scroll-panscroll

Conversation

@Siddhartha20242

Copy link
Copy Markdown
Contributor

Summary

This PR introduces a feature used in Reactflow apps that gives the panscroll feature which helps in scrolling vertically or horizontally without any dependence on the button of mousepad.

Issue Number

151

Closes #151

Screenshots/Video

Does this PR introduce a breaking change?

No

If relevant, did you update the documentation?

No

@Siddhartha20242

Copy link
Copy Markdown
Contributor Author

@AgniveshChaubey Sir, can you please check this i have implemented the panonScroll and also did version bump. Thank you:)

@jagpreetrahi

Copy link
Copy Markdown
Collaborator

@Siddhartha20242 , can you provide the preview of the implementation parts?

onEdgeMouseEnter={(_, edge) => setHoveredEdgeId(edge.id)}
onEdgeMouseLeave={() => setHoveredEdgeId(null)}
panOnScroll={true}
panOnScrollMode={PanOnScrollMode.Free}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siddhartha20242 , this panOnScroolMode enum provides the three property right, and you used one as Free that is for unrestricted panning right? But you mentioned about vertical and horizontal behavior as well in an issue that could be done by using other valid props along with current one as well. What do you think about it? Or is this done job done by using only Free prop ?

@Siddhartha20242

Copy link
Copy Markdown
Contributor Author
IMG_0291.MOV

Hi, @jagpreetrahi brother. I have uploaded the video with my hand moments to show you how you can do that. Also, the thing is Free mode in react flow allows us to control the shift in all 4 directions so we donot need to seperately do all the changes like horizontal and vertical.
Or is this done job done by using only Free prop ? Yes it does as you can see my video for that. Thank you so much for your concern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] There is no horizontal scroll to go to [left, right, up, down] for good user experience like in excalidraw.

2 participants