Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/engin/_assembler.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,10 +424,9 @@ async def _satisfy(self, target: TypeId) -> None:
) from err

if provider.is_multiprovider:
if type_id in self._root_node.cache:
self._root_node.cache[type_id].extend(value)
else:
self._root_node.cache[type_id] = value
if type_id not in self._root_node.cache:
self._root_node.cache[type_id] = []
self._root_node.cache[type_id].extend(value)
elif provider.scope:
scope.cache[type_id] = value
else:
Expand Down
18 changes: 17 additions & 1 deletion tests/test_assembler.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import pytest

from engin import Assembler, Entrypoint, Invoke, Provide
from engin import Assembler, Entrypoint, Invoke, Provide, Supply
from engin.exceptions import NotInScopeError, ProviderError, TypeNotProvidedError
from tests.deps import int_provider, make_many_int, make_many_int_alt, make_str

Expand Down Expand Up @@ -135,6 +135,22 @@ def make_str() -> list[str]:
assert not assembler.has(str)


async def test_assembler_does_not_modify_multiprovider_values():
def multidependency_user(values: list[int]) -> int:
return 42

provider = Provide(multidependency_user)
providers = [Supply([1]), Supply([2]), provider]

assembler1 = Assembler(providers)
assembler2 = Assembler(providers)
await assembler1.assemble(providers[2])
await assembler2.assemble(providers[2])

assert providers[0]._value == [1]
assert providers[1]._value == [2]


async def test_assembler_add():
assembler = Assembler([])
assembler.add(int_provider())
Expand Down
Loading