Skip to content

[uss_quafilier] Lower severity of all cleanup steps#1433

Merged
mickmis merged 1 commit intointeruss:mainfrom
Orbitalize:general_1400
Apr 23, 2026
Merged

[uss_quafilier] Lower severity of all cleanup steps#1433
mickmis merged 1 commit intointeruss:mainfrom
Orbitalize:general_1400

Conversation

@the-glu
Copy link
Copy Markdown
Contributor

@the-glu the-glu commented Apr 22, 2026

This PR finalize #1400 by removing checks that where still too high in cleanup phases.

Most of them used fragments used in non-cleanup phrase. I duplicated them in specific _during_cleanup files, but I'm not sure that the best solution.

This has been tested by running whole CI with something like


        if self._phase == ScenarioPhase.CleaningUp and check_documentation.severity in [
            Severity.High,
            Severity.Critical,
        ]:
            raise RuntimeError()

in monitoring/uss_qualifier/scenarios/scenario.py's check() function, showing no left over checks.

@the-glu the-glu changed the title . [uss_quafilier] Lower severity of all cleanup steps Apr 22, 2026
@the-glu the-glu marked this pull request as ready for review April 22, 2026 17:34
Copy link
Copy Markdown
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to ensure this won't be an issue, what about checking whether we are in the cleanup phase (+ a log entry to have a chance of cleaning that up) here?:

if severity == Severity.High:
raise ScenarioCannotContinueError(f"{severity}-severity issue: {summary}")
if severity == Severity.Critical:
raise TestRunCannotContinueError(f"{severity}-severity issue: {summary}")

(in another PR)

Otherwise LGTM, even though duplication is a bit of y pity, but hard to avoid here.

@mickmis mickmis merged commit 1cfdcb6 into interuss:main Apr 23, 2026
22 checks passed
@the-glu
Copy link
Copy Markdown
Contributor Author

the-glu commented Apr 23, 2026

In order to ensure this won't be an issue, what about checking whether we are in the cleanup phase (+ a log entry to have a chance of cleaning that up) here?:

Yes, but do we want to enforce that? Someone could decide to write a Cleanup check with High severity.

Also should we choose to enforce that, we could also automatically lower severity in cleanup phase (and remove duplicated fragments)

@BenjaminPelletier any opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants