Skip to content

[tooling] Ignore git-ignored files in shell-lint#1430

Merged
mickmis merged 1 commit intointeruss:mainfrom
Orbitalize:fix_1427
Apr 20, 2026
Merged

[tooling] Ignore git-ignored files in shell-lint#1430
mickmis merged 1 commit intointeruss:mainfrom
Orbitalize:fix_1427

Conversation

@the-glu
Copy link
Copy Markdown
Contributor

@the-glu the-glu commented Apr 20, 2026

This PR fixes #1427 by excluding files that are excluded by git ignore files in the shell lint command.

Diffing the file list before & after the extra filter show expected results:

*** /tmp/b      2026-04-20 09:58:38.074510445 +0200
--- /tmp/a      2026-04-20 09:58:28.231460147 +0200
***************
*** 29,36 ****
  ./schemas/manage_type_schemas.sh
  ./github_pages/make_site_content.sh
  ./test/repo_hygiene/repo_hygiene.sh
- ./.venv/lib/python3.13/site-packages/nodejs_wheel/lib/node_modules/npm/lib/utils/completion.sh
- ./.venv/lib/python3.13/site-packages/nodejs_wheel/lib/node_modules/npm/node_modules/node-gyp/macOS_Catalina_acid_test.sh
  ./build/build_and_push.sh
  ./build/dev/startup/core_service.sh
  ./build/dev/run_locally.sh
--- 29,34 ----
***************
*** 38,41 ****
  ./scripts/git/version.sh
  ./scripts/git/commit.sh
  ./scripts/tag.sh
- 
--- 36,38 ----

@mickmis mickmis merged commit e6f354f into interuss:main Apr 20, 2026
22 checks passed
@mickmis
Copy link
Copy Markdown
Contributor

mickmis commented Apr 20, 2026

@the-glu
Copy link
Copy Markdown
Contributor Author

the-glu commented Apr 21, 2026

Do the same for dss https://github.com/interuss/dss/blob/master/Makefile#L95?

Good idea, done there: interuss/dss#1443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make lint does not work locally

2 participants