[store] Squash datastore.Store and datastore.Datastore#1444
Open
the-glu wants to merge 1 commit intointeruss:masterfrom
Open
[store] Squash datastore.Store and datastore.Datastore#1444the-glu wants to merge 1 commit intointeruss:masterfrom
the-glu wants to merge 1 commit intointeruss:masterfrom
Conversation
This was referenced Apr 22, 2026
Open
BenjaminPelletier
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a series of PRs, aiming to fix #1418 with better organization of datastore interfaces.
PRs are chained, and composed of the following:
#1444 : Merge datastore.Store and datastore.Datastore
#1445 : Move initialization into clean datastore.Store interface and use generic stores
#1446 : Rename datastore to sqlstore
#1447 : Move 'CodeRetryable' to generic store package
#1448 : Add 'store_type' flag
#1449 : Show example of new datastore type (not to be merged, demo only).
This PR is the first step, merging both
datastore.Storeanddatastore.Datastore.The difference to provide a specific queryable is probably not used in practice, as various implementations already heavily assume a PostgreSQL-compatible implementation.
A few functions have been inlined, but
Dialis kept separate due to its usage for migrations.