Skip to content

[raft] add no_datastore flag #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MariemBaccari wants to merge 1 commit into from
Closed

[raft] add no_datastore flag #1442

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 24 additions & 12 deletions cmds/core-service/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,8 @@ var (
jwtAudiences = flag.String("accepted_jwt_audiences", "", "comma-separated acceptable JWT `aud` claims")

scdGlobalLock = flag.Bool("enable_scd_global_lock", false, "Experimental: Use a global lock when working with SCD subscriptions. Reduce global throughput but improve throughput with lot of subscriptions in the same areas.")

noDatastore = flag.Bool("no_datastore", false, "Disables the datastore and uses Raft consensus for synchronization instead")
)

func createKeyResolver() (auth.KeyResolver, error) {
Expand Down Expand Up @@ -167,16 +169,20 @@ func RunHTTPServer(ctx context.Context, ctxCanceler func(), address, locality st
ctx, ctxCancel := context.WithCancel(ctx)
defer ctxCancel()

// Initialize aux
auxV1Server, err = createAuxServer(ctx, locality, *publicEndpoint, *scdGlobalLock, logger)
if err != nil {
return stacktrace.Propagate(err, "Failed to create aux server")
}
if *noDatastore {
logger.Warn("Skipping Aux and RID when the datastore is disabled")
} else {
// Initialize aux
auxV1Server, err = createAuxServer(ctx, locality, *publicEndpoint, *scdGlobalLock, logger)
if err != nil {
return stacktrace.Propagate(err, "Failed to create aux server")
}

// Initialize remote ID
ridV1Server, ridV2Server, err = createRIDServers(ctx, locality, logger)
if err != nil {
return stacktrace.Propagate(err, "Failed to create remote ID server")
// Initialize remote ID
ridV1Server, ridV2Server, err = createRIDServers(ctx, locality, logger)
if err != nil {
return stacktrace.Propagate(err, "Failed to create remote ID server")
}
}

// Initialize access token validation
Expand Down Expand Up @@ -213,9 +219,15 @@ func RunHTTPServer(ctx context.Context, ctxCanceler func(), address, locality st

// Initialize strategic conflict detection
if *enableSCD {
scdV1Server, err = createSCDServer(ctx, logger)
if err != nil {
return stacktrace.Propagate(err, "Failed to create strategic conflict detection server")
if *noDatastore {
logger.Info("Starting SCD Server with datastore disabled")
logger.Warn("SCD server in this mode is not yet implemented")
// TODO
} else {
scdV1Server, err = createSCDServer(ctx, logger)
if err != nil {
return stacktrace.Propagate(err, "Failed to create strategic conflict detection server")
}
}

scdV1Router := apiscdv1.MakeAPIRouter(scdV1Server, authorizer)
Expand Down
Loading