Skip to content

[rid/datastore/ListExpired(Subscriptions|ISAs)] Properly escape writer; Fix removal of expired entities with NULL writer (empty locality)#1436

Merged
mickmis merged 1 commit intointeruss:masterfrom
Orbitalize:fix_writer
Apr 22, 2026

Conversation

@the-glu
Copy link
Copy Markdown
Contributor

@the-glu the-glu commented Apr 15, 2026

I noticed that List* directly inject the writer parameter into the SQL query.

That not great at it could lead to SQL injections (and won't works with special values). Right now it's only used by evict and is coming from a flag, not from http queries, so it's not a security issue. However, it seems safer to escape it, for best practices and avoid potential issue when used in the future in other contexts.

This also fix the case with "", the = NULL condition won't match NULL values.

@mickmis mickmis changed the title Escape writer in ListExpired*, fix empty queries [rid/datastore/ListExpired(Subscriptions|ISAs)] Properly escape writer; Fix removal of expired entities with NULL writer (empty locality) Apr 16, 2026
Copy link
Copy Markdown
Contributor

@mickmis mickmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change LGTM. I updated the title to reflect more accuratly the change. Could you just add a note in the next release notes about the fix on the null writer? This could have a visible impact on users, as it may clean up expired entities that were not cleaned up previously. That's the case if the DSS instance was not specifying any 'locality'.

@the-glu
Copy link
Copy Markdown
Contributor Author

the-glu commented Apr 21, 2026

Code change LGTM. I updated the title to reflect more accuratly the change. Could you just add a note in the next release notes about the fix on the null writer? This could have a visible impact on users, as it may clean up expired entities that were not cleaned up previously. That's the case if the DSS instance was not specifying any 'locality'.

Done, I let you check the wording ;)

@the-glu the-glu requested a review from mickmis April 21, 2026 14:28
@mickmis mickmis merged commit 08edd4b into interuss:master Apr 22, 2026
12 checks passed
@mickmis mickmis deleted the fix_writer branch April 22, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants