Checks for package name instead of full file name in python tests#1064
Merged
isc-jlechtne merged 1 commit intomainfrom Feb 4, 2026
Merged
Checks for package name instead of full file name in python tests#1064isc-jlechtne merged 1 commit intomainfrom
isc-jlechtne merged 1 commit intomainfrom
Conversation
isc-jlechtne
changed the title
Collaborator
Author
|
While the initial cause of the problem was one file and updating that should fix it, these tests would be susceptible in the future to the same error, this fixes that. If a dependency itself gets removed causing these tests to fail, that would require another update to the tests but that should happen much less frequently than a dependency version being changed. |
isc-jlechtne
requested review from
isc-cborbonm,
isc-dchui,
isc-egabhart,
isc-eneil,
isc-jili,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-dchui
approved these changes
Feb 4, 2026
isc-jili
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An issue was found in a later PR where the specific version of the file installed via requirements.txt in one of the python wheels tests changed. When it came to checking for files being a part of the packaged module, this changed the wheel file name and caused the checks to fail. This change compiles a list of the wheels present and just checks for a substring (package name).