fix(eslint): promote 5 clean Vue lint rules to error (#13510) - #13512
Merged
RayBB merged 1 commit intoSep 1, 2026
Conversation
RayBB
approved these changes
Sep 1, 2026
RayBB
left a comment
Collaborator
There was a problem hiding this comment.
Thanks very much. This solves it and is great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13510
[fix]
Promotes 5 Vue ESLint rules from
warntoerrorineslint.config.cjs, now that all existing violations were cleaned up by #13473 and #13479. This prevents new violations of these rules from silently accumulating again.Technical
Added the following to the
**/*.vue/**/*.jsrules block ineslint.config.cjs, next to the existingvue/multi-word-component-namesentry:These rules previously came from
eslint-plugin-vue'sflat/recommendedconfig at thewarnlevel, and CI does not fail on warnings — so violations could merge unnoticed. All 5 were already at zero violations on master before this change (confirmed by prior cleanup PRs #13473 and #13479), so this flip is zero-cost today and only affects future PRs.Per the issue, the other ~25
warnrules inflat/recommended(mostly formatting rules likevue/html-indent) were intentionally not promoted, since they'd add CI friction without meaningful safety value.Testing
npm run lint(eslint .+stylelint) on the branch — both exit with code 0, 0 errors, 0 warnings.git diff --stat masterthat onlyeslint.config.cjswas changed (5 insertions, 0 deletions).git grep -n "eslint-disable" $(git diff --name-only master)that noeslint-disablecomments were added anywhere to force the pass, per the acceptance criteria.Screenshot
N/A — config-only change, no UI impact.
Stakeholders
@RayBB