Handle enter event on pathway filter to allow free text( write and press enter key)#103
Open
shaymaa91 wants to merge 2 commits intointermine:masterfrom
Open
Handle enter event on pathway filter to allow free text( write and press enter key)#103shaymaa91 wants to merge 2 commits intointermine:masterfrom
shaymaa91 wants to merge 2 commits intointermine:masterfrom
Conversation
Author
|
@AdrianBZG @Nikhil-Vats could you please review this and let me know your notes even if this will not be accepted? |
Author
|
Hi @Nikhil-Vats @AdrianBZG Sorry for chasing again, but could you please give me any update, any note? any directions about the code I used to solve the issue. Thank you :) |
AdrianBZG
pushed a commit
that referenced
this pull request
Sep 3, 2020
This commit adds the feature for generating visualizations for template queries. There are now two available sections to run queries from: 1. Overview 2. Templates Templates are pre-filtered by the selected class, and can be further filtered by selecting a category. Each category displays the total count of its templates. Note that some templates may be in more than one category, so tallying the category counts may not match the total count. The `Show All` category does display the correct total though. Currently the constraints within the templates fetch their values each time the popup is opened, and do not cache them when the components unmount. The same is true for fetching templates. This will be addressed in another story. Closes: #102 Squashed commits: * Allow switching between default and template views * Rename "supervisor" to "appManager" * Lift the default constraints into the app manager component * Lift switching app views to the app manager component * Display when no queries have been executed * Render category tags * Place category tags in an accordion * Display just the "Run Query" button for templates * Filter template constraints per class * Filter templates by selected categories * Remove categories with no available templates * Display the count for each category * Display only the tags for the selected class view * Render checkbox items for ONE OF constraints * Update the template query with the newly selected values * Run a query and update visualizations * Fetch values for a template constraint * Display a tag above a constraint widget for every selected value * Display the operation next to constraint widget tags * Display success icon if the template query had been executed * Display the description when hovering over the info icon * Disable the QueryController for template view * Display notification when no constraint items were received * Extract categories to prevent Template component re-renders * Update the categories when changing classes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I added event handler on keyup for the pathway names section only, inside the handler I check if the pressed key is the enter key, if so the code will check for the entered value about two conditions, the first condition if the whole entered word is exists, then update the view as the same way SELECT in the AUTOCOMPLETE code part, if not check if the entered value is a part of an existing value, then show the suggestions we have for this part of word, else rather than previous which means the entered value does not exist, then show an error message says " the value dose not exists" below the Pathways Input search Field.
Related issues and discussion
#49