Skip to content

Conversation

@bosbaber
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configurable Kubernetes API versions and version specification for chart validation. It introduces two new command-line flags: --api-versions for passing additional Kubernetes API versions to Helm, and --k8s-version for specifying the Kubernetes version used in manifest validation and chart rendering.

Key Changes

  • Added --api-versions and --k8s-version command-line flags to both run-checks and render-only commands
  • Integrated API versions into Helm chart rendering with --api-versions and --kube-version flags
  • Enhanced kubeconform validation with -kubernetes-version and -skip CustomResourceDefinition flags
  • Improved schema path handling with absolute paths and multiple schema location patterns

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
chartvalidator/checker/main.go Added command-line flags for API versions and Kubernetes version, updated function signatures to pass these parameters through the execution pipeline
chartvalidator/checker/engine_chart_rendering.go Implemented API versions support in Helm rendering by appending --api-versions flags and --kube-version to helm template commands
chartvalidator/checker/engine_manifest_validation.go Enhanced kubeconform validation with Kubernetes version specification, CRD skipping, and improved schema path handling with absolute paths
chartvalidator/checker/engine_app_checker.go Updated engine constructor to accept and propagate API versions, added schema directory initialization with absolute path resolution
chartvalidator/checker/engine_chart_rendering_test.go Updated test expectations to include new --kube-version and --api-versions flags in helm commands
chartvalidator/checker/engine_manifest_validation_test.go Modified test assertions to verify new kubeconform flags including -skip CustomResourceDefinition and -kubernetes-version
chartvalidator/checker/types.go Aligned struct field formatting for consistency
chartvalidator/checker/appsets.go Minor formatting cleanup (trailing newline)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bosbaber bosbaber changed the title feat: api versions support feat(checker): api versions support Nov 26, 2025
@bosbaber bosbaber changed the title feat(checker): api versions support feat(chartvalidator): api versions support Nov 26, 2025
@bosbaber bosbaber force-pushed the bosbaber/20251126-apiversions-support branch from b29d09b to 4646d80 Compare November 26, 2025 13:19
@bosbaber bosbaber merged commit cf90efa into main Nov 26, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants