Skip to content

Apply Shane's review: imported rules, state filter, and corrections - #52

Merged
CandiceChislett merged 1 commit into
mainfrom
alerting-shane-edits
Sep 30, 2026
Merged

CandiceChislett merged 1 commit into
mainfrom
alerting-shane-edits

Conversation

@CandiceChislett

Copy link
Copy Markdown
Collaborator

Adds an Imported Rules page, from Shane's write-up. Rules carried over from FusionReactor Alerts keep their original format, with the condition inside the query rather than in a Threshold step, and a prometheus_math Math step between Query and Threshold. The page covers recognizing one, why the chart draws a threshold of 0, the imported vs standard comparison, how to update one, and the two edge cases that change afterwards. Linked from the Alerting overview and Alert Rules.

Corrections from the same review:

  • The state filter starts on Firing, Error, Pending and Recovering, so healthy rules are not listed by name until it is widened. A card's chips count everything it holds regardless of the filter, which is why a card can read Normal 11 while listing one Pending rule. The Status page previously described this as promotion rather than filtering
  • Recovering no longer refers to a Keep firing for period, and the flapping fix that recommended that field is removed. The field was never added to the rule form
  • The expanded rule view shows Namespace, not Data source
  • Updating an imported rule on a duplicate is a recommendation rather than the procedure
  • Contact points gain a note on OpsGenie's removal, pointing at Jira Service Management and Atlassian's migration guide

Adds an Imported Rules page, from Shane's write-up. Rules carried over
from FusionReactor Alerts keep their original format, with the condition
inside the query rather than in a Threshold step, and a prometheus_math
Math step between Query and Threshold. The page covers recognizing one,
why the chart draws a threshold of 0, the imported vs standard
comparison, how to update one, and the two edge cases that change
afterwards. Linked from the Alerting overview and Alert Rules.

Corrections from the same review:

- The state filter starts on Firing, Error, Pending and Recovering, so
  healthy rules are not listed by name until it is widened. A card's
  chips count everything it holds regardless of the filter, which is why
  a card can read Normal 11 while listing one Pending rule. The Status
  page previously described this as promotion rather than filtering
- Recovering no longer refers to a Keep firing for period, and the
  flapping fix that recommended that field is removed. The field was
  never added to the rule form
- The expanded rule view shows Namespace, not Data source
- Updating an imported rule on a duplicate is a recommendation rather
  than the procedure
- Contact points gain a note on OpsGenie's removal, pointing at Jira
  Service Management and Atlassian's migration guide

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@CandiceChislett
CandiceChislett merged commit 094b57c into main Sep 30, 2026
4 checks passed
@codehub-agent

codehub-agent Bot commented Sep 30, 2026

Copy link
Copy Markdown

💰 Agent economics

no agent sessions have reported to this workspace in the last 30 days, so there is no spend to attribute. Set up agent telemetry →

Full economics → · by CodeHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant