Apply Shane's review: imported rules, state filter, and corrections - #52
Merged
Merged
Conversation
Adds an Imported Rules page, from Shane's write-up. Rules carried over from FusionReactor Alerts keep their original format, with the condition inside the query rather than in a Threshold step, and a prometheus_math Math step between Query and Threshold. The page covers recognizing one, why the chart draws a threshold of 0, the imported vs standard comparison, how to update one, and the two edge cases that change afterwards. Linked from the Alerting overview and Alert Rules. Corrections from the same review: - The state filter starts on Firing, Error, Pending and Recovering, so healthy rules are not listed by name until it is widened. A card's chips count everything it holds regardless of the filter, which is why a card can read Normal 11 while listing one Pending rule. The Status page previously described this as promotion rather than filtering - Recovering no longer refers to a Keep firing for period, and the flapping fix that recommended that field is removed. The field was never added to the rule form - The expanded rule view shows Namespace, not Data source - Updating an imported rule on a duplicate is a recommendation rather than the procedure - Contact points gain a note on OpsGenie's removal, pointing at Jira Service Management and Atlassian's migration guide Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
💰 Agent economicsno agent sessions have reported to this workspace in the last 30 days, so there is no spend to attribute. Set up agent telemetry → Full economics → · by CodeHub |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an Imported Rules page, from Shane's write-up. Rules carried over from FusionReactor Alerts keep their original format, with the condition inside the query rather than in a Threshold step, and a prometheus_math Math step between Query and Threshold. The page covers recognizing one, why the chart draws a threshold of 0, the imported vs standard comparison, how to update one, and the two edge cases that change afterwards. Linked from the Alerting overview and Alert Rules.
Corrections from the same review: