Add token/s on dashboard and reporting token/s in the metrics endpoint - #263
Closed
ndragon798 wants to merge 5 commits into
Closed
Add token/s on dashboard and reporting token/s in the metrics endpoint#263ndragon798 wants to merge 5 commits into
ndragon798 wants to merge 5 commits into
Conversation
Contributor
|
@ndragon798 Hey! Thanks a lot, at a frst glance looks good. :) We will test it with @malzag on a few devices, and will likely merge it if nothing comes up. |
Author
|
Didn't realize I made the pr with my main branch let me close this and remake it with a proper branch so my other changes don't keep get added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added reporting tokens per second in the dashboard and total tokens per second in metrics

From the metrics endpoint
This is done by counting the amount of generation in the SampleTokenPhase then its sent off to a throughput meter which is just a rolling 1 second window. This is sent from the agent via the status snapshot that the agent sends once per second. Lots of this was done by Claude with me fixing issues that it had with building the binaries and testing. I only was able to test this on 3 machines that are amd/cpu based. I don't think there will be any issues with nvidia but please test if you have an nvidia gpu. Also tested with the desktop app which only seems to do cpu and not vulkan?
Let me know if you have any questions or run into any issues.
Thanks,
Nathan