Revert "Add subgroup topk kernel for XPU (part1 of #3369) (#3371)"#3707
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reverts the subgroup top-k XPU optimization that caused build timeouts with multiple AOT targets, restoring the existing segmented top-k path while removing the dedicated subgroup kernel files.
Review context: read .github/skills/xpu-ops-pr-review/SKILL.md.
Changes:
- Removes the subgroup top-k kernel implementation and declaration.
- Removes the optimized-path dispatch from
topk_kernel. - Restores unconditional use of
segmented_group_select_pairsfollowed by optional sorting.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/ATen/native/xpu/sycl/TensorTopKSbtopkKernel.h |
Deletes the subgroup top-k API declarations. |
src/ATen/native/xpu/sycl/TensorTopKSbtopkKernel.cpp |
Deletes the subgroup top-k kernel implementation and launch logic. |
src/ATen/native/xpu/sycl/TensorTopKKernel.cpp |
Restores the original top-k execution path without subgroup dispatch. |
jianyizh
left a comment
There was a problem hiding this comment.
Please write clear in description that it's reverted because of long build time in CD
Updated. |
|
I saw the build passed and landed it immediately since the change only removed code. We need to update commit pin as soon as possible to unblock pytorch/pytorch#173895 PyTorch CI. |
|
@copilot New UT failures detected in op_ut tests (7 total). Please check these new failures and analyze whether they are caused by the PR changes. Important: Do NOT update the plan in the PR description directly. Use reply comments to update the status. Job log: https://github.com/intel/torch-xpu-ops/actions/runs/26078819694 New failures:
... and 2 more failures. See full list in artifact. Instructions:
|
Performance outliers, please check!
|
This reverts commit 8eaa591, except new overloads of
sycl_kernel_submit.The motivation is that #3371 caused build timeout in stock CD.