Make test binaries and test data installable#57
Open
nefigtut wants to merge 2 commits into
Open
Conversation
Build gtest library as static, build tests with it and make test executables installable artifacts. Make test dataset used by the test binaries installable as well. Signed-off-by: Vladislav Dronov <vdronov@redhat.com>
Signed-off-by: Vladislav Dronov <vdronov@redhat.com>
nefigtut
requested review from
ElenaTyuleneva,
gbtucker,
nmizonov,
paveldyakov and
tizmajlo
as code owners
Author
|
Hi, i'm a developer adding the intel-qpl package to RedHat Linux per Intel request. I'm not sure if this change is needed here upsteam, so please feel free to drop this PR out. Still, RHEL (and probably other distributions) would want test binaries available as build artifacts to run them during their QE stage outside the build process. So, this PR suggests building gtest library as static, so not to conflict with a system gtest if present and to lock possibly outdated gtest lib inside test binaries. Then it is used to build test binaries (which have to be renamed: qpl-func-tests and qpl-cross-tests). Could you please consider this PR for a possible inclusion? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build gtest library as static, build tests with it and make test
executables installable artifacts. Make test dataset used by the
test binaries installable as well. Also fix a small shebang issue.