Skip to content

Omni: Add contiguous check for omni_xpu_kernel input #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xiangyuT wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Draft

Omni: Add contiguous check for omni_xpu_kernel input #427

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions omni/patches/comfyui_for_multi_arc.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ index 7a9b4b84..1a02c4dd 100644
import torch
import logging
import comfy.model_management
@@ -29,6 +30,45 @@ import comfy.utils
@@ -29,6 +30,47 @@ import comfy.utils
import comfy_aimdo.model_vbar
import comfy_aimdo.torch

Expand Down Expand Up @@ -411,6 +411,8 @@ index 7a9b4b84..1a02c4dd 100644
+ return False
+ if not x.is_xpu:
+ return False
+ if not x.is_contiguous():
+ return False
+ if x.ndim < 2:
+ return False
+ hidden_size = x.shape[-1]
Expand Down Expand Up @@ -643,7 +645,7 @@ diff --git a/comfy/rmsnorm.py b/comfy/rmsnorm.py
index ab7cf14f..91f46d15 100644
--- a/comfy/rmsnorm.py
+++ b/comfy/rmsnorm.py
@@ -1,9 +1,60 @@
@@ -1,9 +1,62 @@
+import os
import torch
+import logging
Expand Down Expand Up @@ -675,6 +677,8 @@ index ab7cf14f..91f46d15 100644
+ return False
+ if not x.is_xpu:
+ return False
+ if not x.is_contiguous():
+ return False
+ if x.ndim < 2:
+ return False
+ hidden_size = x.shape[-1]
Expand Down