backport: Add error handling for unsupported flavor options - #375
Open
pravalikagurram1 wants to merge 1 commit into
Open
backport: Add error handling for unsupported flavor options#375pravalikagurram1 wants to merge 1 commit into
pravalikagurram1 wants to merge 1 commit into
Conversation
ayazahma
requested changes
Apr 27, 2026
ayazahma
left a comment
ayazahma
left a comment
Contributor
There was a problem hiding this comment.
there is no point to have two commits , they should merge togather
I think we should provide , also in case error , we should just print waring that un supporrted option and fall back to default
Contributor
|
Also This change is not critical, so I suggest completing functional implementier oot backport Change etc along with these Change can I have pr for backport tool, to use oot option |
pravalikagurram1
force-pushed
the
backport_shell
branch
from
April 28, 2026 08:23
1404110 to
c50a59e
Compare
Add an else case to the flavor validation logic in apply_patches() to handle invalid or unsupported flavor specifications. When a user provides a flavor that is not in the supported list (base, features, oot), the script now displays an error message with the list of supported options and exits with error status code 1, instead of silently continuing." Refactor: Use switch statement for flavor selection in apply_patches() Convert nested if-elif-else logic to a switch/case statement for improved readability. No functional changes - only refactoring for better code structure. Signed-off-by: Pravalika Gurram <pravalika.gurram@intel.com>
pravalikagurram1
force-pushed
the
backport_shell
branch
from
April 28, 2026 14:38
c50a59e to
58f684a
Compare
smuqthya
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an else case to the flavor validation logic in apply_patches() to
handle invalid or unsupported flavor specifications. When a user
provides a flavor that is not in the supported list (base, features, oot),
the script now displays an error message with the list of supported options
and exits with error status code 1, instead of silently continuing."
Signed-off-by: Pravalika Gurram pravalika.gurram@intel.com