Skip to content

espressif: fix bootloader build when UF2_DETECTION_DELAY_MS is 0 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SukuWc merged 2 commits into from
Oct 19, 2026
Merged

espressif: fix bootloader build when UF2_DETECTION_DELAY_MS is 0 #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ad44fd6
espressif: fix bootloader build when UF2_DETECTION_DELAY_MS is 0
SukuWc Oct 19, 2026
cfaac18
espressif: keep the original operand order in the detection loop
SukuWc Oct 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ports/espressif/bootloader_components/main/bootloader_start.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,14 +236,15 @@ static int selected_boot_partition(const bootloader_state_t *bs) {
esp_rom_gpio_pad_pullup_only(PIN_BUTTON_UF2);

// run the GPIO detection at least once even if UF2_DETECTION_DELAY_MS is set to zero
uint32_t const detection_delay_ms = UF2_DETECTION_DELAY_MS;
uint32_t tm_start = esp_log_early_timestamp();
do {
if ( gpio_ll_get_level(&GPIO, PIN_BUTTON_UF2) == 0 ) {
ESP_LOGI(TAG, "Detect GPIO %d active to enter UF2 bootloader", PIN_BUTTON_UF2);
boot_index = FACTORY_INDEX;
break;
}
} while (UF2_DETECTION_DELAY_MS > (esp_log_early_timestamp() - tm_start) );
} while (detection_delay_ms > (esp_log_early_timestamp() - tm_start) );

if (UF2_DETECTION_DELAY_MS > 0){
board_led_off();
Expand Down
Loading