chore(security): fix npm audit vulnerabilities in sample-app#90
Draft
calebwilson706 wants to merge 1 commit into
Draft
chore(security): fix npm audit vulnerabilities in sample-app#90calebwilson706 wants to merge 1 commit into
calebwilson706 wants to merge 1 commit into
Conversation
Resolves npm audit alerts in exercises/sample-app. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes npm audit vulnerabilities in
exercises/sample-app. Applied the safenpm audit fixplus the breakingnpm audit fix --force, both verified against typecheck and unit tests.Audit results
npm audit fix(safe)npm audit fix --force+ safe fixPackages bumped
Safe fix (transitive, resolved via package-lock only):
path-to-regexp,postcss,qs(viaexpress/body-parser),rollupand related sub-dependencies.Breaking fix (applied, KEPT):
vitest^1.0.0→^4.1.10(SemVer major). This pulled forward the vulnerableesbuild/vite/vite-nodechain used only by the test runner.vitestis a devDependency, so runtime is unaffected.Verification
npm run typecheck(tsc --noEmit)npm test(vitest run)Tests and typecheck are no worse than baseline, so the breaking
vitestv4 upgrade was kept. Playwright e2e was intentionally not run (requires browser install); typecheck + unit tests are sufficient verification per scope.Remaining / deferred
esbuild(GHSA-g7r4-m6w7-qqqr, arbitrary file read on the dev server, Windows only) nested undertsx(node_modules/tsx/node_modules/esbuild).npm audit fixreports a fix as available but is a no-op — it cannot be resolved without an upstreamtsxupdate. Low severity, dev-server only, deferred.🤖 Generated with Claude Code