Skip to content

Show proxied connections on the overview page - #2852

Open
dwwoelfel wants to merge 1 commit into
mainfrom
proxied-on-overview
Open

Show proxied connections on the overview page#2852
dwwoelfel wants to merge 1 commit into
mainfrom
proxied-on-overview

Conversation

@dwwoelfel

@dwwoelfel dwwoelfel commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Shows the number of proxied connections on the minute section of the /intern/overview page.

Deployment plan

  1. Wait for PR to fully deploy and for all old machines to scale out
  2. Flip the proxied-connections-overview-enabled flag to true

@coderabbitai

coderabbitai Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The server now reports proxied WebSocket connections through the admin overview API. The intern overview aggregates these records by app and displays counts, app IDs, and target URIs when data is available.

Changes

Proxied connection overview

Layer / File(s) Summary
Collect and cache proxied connections
server/src/instant/app_proxy.clj, server/src/instant/machine_summaries.clj
App-proxy instances report local connection counts and target URIs. Machine summaries aggregate the results and cache them for five seconds.
Expose proxied connections in the admin response
server/src/instant/dash/routes.clj
The admin overview response includes cached proxied-connection data when the feature flag is enabled.
Aggregate and display overview data
client/www/pages/intern/overview.tsx
The page aggregates records by app, sorts them by count, computes totals, and conditionally renders a proxied-connections table.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant InternOverview
  participant AdminOverview
  participant MachineSummaries
  participant AppProxy
  InternOverview->>AdminOverview: Request minute overview
  AdminOverview->>MachineSummaries: Read cached proxied connections
  MachineSummaries->>AppProxy: Collect local connection counts and targets
  AppProxy-->>MachineSummaries: Return local proxied connections
  MachineSummaries-->>AdminOverview: Return cached summaries
  AdminOverview-->>InternOverview: Return overview with proxied connections
  InternOverview->>InternOverview: Aggregate records by app and render table
Loading

Possibly related PRs

  • instantdb/instant#2802: Adds the app-proxy routing code that tracks the connections reported by this change.

Suggested reviewers: stopachka

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the main change: displaying proxied connections on the overview page.
Description check ✅ Passed The description explains the proxied-connections change and includes a deployment plan related to the feature flag.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

View Vercel preview at instant-www-js-proxied-on-overview-jsv.vercel.app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant