Skip to content

Grammar fixes for self host - #2848

Merged
nezaj merged 1 commit into
mainfrom
sm-self-host-grammar
Aug 7, 2026
Merged

Grammar fixes for self host#2848
nezaj merged 1 commit into
mainfrom
sm-self-host-grammar

Conversation

@nezaj

@nezaj nezaj commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What it says on the tin!

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated self-hosting documentation for hosting selection, configuration, AWS deployment, and migration procedures. Changes clarify wording, present-tense descriptions, punctuation, formatting, and private DNS instructions without changing APIs or procedures.

Changes

Self-hosting documentation

Layer / File(s) Summary
Self-hosting setup guidance
client/www/app/docs/self-hosting/page.md
Clarifies hosting-guide selection, Postmark delivery, Google login, CLI authentication, URI configuration, and generated configuration.
Migration procedure wording
client/www/app/docs/self-hosting/migrate/page.md
Reformats and clarifies webhook setup, backup validation, client updates, app ID, cutover, and OAuth instructions.
AWS deployment guidance
client/www/app/docs/self-hosting/aws/page.md
Updates architecture terminology and formats the private DNS requirement with inline tasks.server guidance.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: stopachka

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive The description uses a vague idiom and does not provide meaningful details about the documentation changes. Replace the idiom with a brief summary of the grammar and wording updates in the self-hosting documentation.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies grammar changes in self-hosting documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@client/www/app/docs/self-hosting/page.md`:
- Around line 19-21: Update the self-hosting setup instructions to make
“migrating from Instant Cloud” an explicit hosting choice alongside side
projects and startups. Direct migration requests to the Migrate guide, while
preserving the existing cost guidance and VPS/AWS selection for the other
choices.
- Around line 132-134: Update the create-instant-app documentation to state that
both INSTANT_CLI_API_URI and INSTANT_CLI_DASH_URI must be provided for the
self-hosted dashboard URL to be added to instant.config.ts, while preserving the
existing authentication context.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 20582988-79cd-484d-8802-0069bf38d3f9

📥 Commits

Reviewing files that changed from the base of the PR and between 1b9eaef and 729cbd0.

📒 Files selected for processing (3)
  • client/www/app/docs/self-hosting/aws/page.md
  • client/www/app/docs/self-hosting/migrate/page.md
  • client/www/app/docs/self-hosting/page.md

Comment thread client/www/app/docs/self-hosting/page.md
Comment thread client/www/app/docs/self-hosting/page.md
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

View Vercel preview at instant-www-js-sm-self-host-grammar-jsv.vercel.app.

@nezaj nezaj mentioned this pull request Aug 7, 2026

@stopachka stopachka left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@nezaj
nezaj merged commit 58340c4 into main Aug 7, 2026
29 checks passed

@dwwoelfel dwwoelfel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nezaj
nezaj deleted the sm-self-host-grammar branch August 7, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants