Skip to content

[Easy] Add back extra fields guest auth test - #2834

Merged
nezaj merged 1 commit into
mainfrom
sm-e2e-extra-fields-test
Aug 4, 2026
Merged

[Easy] Add back extra fields guest auth test#2834
nezaj merged 1 commit into
mainfrom
sm-e2e-extra-fields-test

Conversation

@nezaj

@nezaj nezaj commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Follow up from #2833

Once we deploy the backend changes this should pass CI!

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The pull request activates the guest-user extraFields end-to-end test. The test signs in a guest, verifies guest status, queries the created user, and checks that the username and display name fields persist.

Changes

Guest extraFields validation

Layer / File(s) Summary
Activate guest extraFields test
client/packages/core/__tests__/src/auth-extra-fields.e2e.test.ts
The test signs in a guest with username and display name fields. It verifies guest status and persisted field values.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested reviewers: stopachka

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the restored guest authentication test for extra fields.
Description check ✅ Passed The description explains that the test follows PR #2833 and depends on backend deployment.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sm-e2e-extra-fields-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

View Vercel preview at instant-www-js-sm-e2e-extra-fields-test-jsv.vercel.app.

@nezaj
nezaj merged commit 7fa046b into main Aug 4, 2026
47 of 49 checks passed
@nezaj
nezaj deleted the sm-e2e-extra-fields-test branch August 4, 2026 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant