Use configured backend for OAuth callbacks - #2822
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR derives OAuth callback URLs from configured API URIs. The CLI uses these URLs across add and update flows. Dashboard OAuth instructions use API-derived fallback URLs. Tests cover URL normalization and propagation. ChangesOAuth callback configuration
Estimated code review effort: 3 (Moderate) | ~30 minutes Sequence Diagram(s)sequenceDiagram
participant CLICommand
participant CLIConfig
participant OAuthProviders
participant RedirectPrompts
CLICommand->>CLIConfig: Resolve configured callback URL
CLIConfig-->>CLICommand: Return normalized callback URL
CLICommand->>OAuthProviders: Pass callback URL to add or update handlers
OAuthProviders->>RedirectPrompts: Render redirect guidance and setup messages
RedirectPrompts-->>OAuthProviders: Use configured callback URL
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View Vercel preview at instant-www-js-fix-self-host-oauth-callbacks-jsv.vercel.app. |
Previously, OAuth setup in the dashboard and CLI always used Instant Cloud’s callback URL.
This change derives the callback from the configured API URL so self-hosted deployments use their own backend!