[Docs] Specify INSTANT_CLI_DASH_URI - #2812
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe CLI now supports configuring a custom dashboard URI, validates configured dashboard URLs, preserves environment overrides, and documents dashboard and API URI settings for self-hosted deployments. The shared package version is updated to v1.0.56. ChangesDashboard URI Configuration
Package Version Update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@client/packages/cli/src/lib/http.ts`:
- Around line 170-176: Update the environment override branch in the HTTP
configuration flow to validate setEnv.value with the same HttpUrl schema used
for the config-file value before returning it. Map validation failures to
BadArgsError consistently with the existing configuration path, and only return
the validated URI.
In `@client/www/app/docs/self-hosting/page.md`:
- Around line 175-185: Split the combined shell example into separate
copy-enabled blocks for the Local Machine Deployment and Server Deployment
commands, keeping each block’s corresponding environment variables and npx
instant-cli@latest init command together.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 05a29969-365b-4c45-a896-8054ea1c53c1
📒 Files selected for processing (3)
client/packages/cli/src/lib/http.tsclient/packages/cli/src/util/instantConfig.tsclient/www/app/docs/self-hosting/page.md
|
View Vercel preview at instant-www-js-add-dash-uri-jsv.vercel.app. |
When using the CLI with self hosted you also need to specify INSTANT_CLI_DASH_URI otherwise you won't connect to the right dashboard to authenticate.
This updates the docs and also updates so our
instant.config.tscan accept this param too