Skip to content

catch and log persistedObject GC errors (#2799) [bump to v1.0.53] - #2799

Merged
drew-harris merged 2 commits into
mainfrom
drewh/log-gc-errors
Jul 28, 2026
Merged

catch and log persistedObject GC errors (#2799) [bump to v1.0.53]#2799
drew-harris merged 2 commits into
mainfrom
drewh/log-gc-errors

Conversation

@drew-harris

@drew-harris drew-harris commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

fixes: #2795
If indexeddb was unavailable for whatever reason, the scheduled 60s garbage collection would throw an uncaught error. This catches the error and logs it instead.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f891302c-25ff-44b2-8493-abb3826e87a2

📥 Commits

Reviewing files that changed from the base of the PR and between 97c708c and b08c313.

📒 Files selected for processing (1)
  • client/packages/version/src/version.ts

📝 Walkthrough

Walkthrough

Scheduled persisted-object garbage collection now catches _gc() failures and logs them through the instance logger. The shared package version is updated from v1.0.52 to v1.0.53.

Changes

GC Handling and Release Metadata

Layer / File(s) Summary
Handle scheduled GC failures
client/packages/core/src/utils/PersistedObject.ts
The scheduled gc() execution attaches a rejection handler to _gc() and logs failures with _log.error.
Increment package version
client/packages/version/src/version.ts
The exported version constant is updated from v1.0.52 to v1.0.53.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: catching and logging PersistedObject GC errors.
Description check ✅ Passed The description describes the same IndexedDB GC error handling fix as the code changes.
Linked Issues check ✅ Passed The patch catches _gc() failures and logs them, which addresses the unhandled rejection storm in #2795.
Out of Scope Changes check ✅ Passed The version bump appears to be release bookkeeping and doesn't introduce unrelated functionality beyond the issue fix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch drewh/log-gc-errors

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

View Vercel preview at instant-www-js-drewh-log-gc-errors-jsv.vercel.app.

@drew-harris
drew-harris marked this pull request as ready for review July 28, 2026 20:28

@dwwoelfel dwwoelfel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drew-harris drew-harris changed the title catch and log persistedObject GC errors catch and log persistedObject GC errors (#2799) [bump to v1.0.53] Jul 28, 2026
@drew-harris
drew-harris merged commit 12a9ead into main Jul 28, 2026
30 checks passed
@drew-harris
drew-harris deleted the drewh/log-gc-errors branch July 28, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Floating _gc() promise causes unhandled rejection storm every minute when IndexedDB fails

2 participants