Added an option to set Default Playback Speed#124
Open
ijzm wants to merge 2 commits into
Open
Conversation
Author
|
Rebased with main to fix merge errors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to allow user to change the default playback speed on videos.
Added an option "defaultPlaybackSpeed" defaulting to 1.0 to "Video pages"
Testing
I did some testing on Firefox & Chrome desktop on Windows
To Do:
Probably needs to add locales for fr, ja & zh_CN. Let me know if I should just use Google Translate, to add those
Let me know if it is okay, or if I should add/change anything else. Love the extension!