Skip to content

Add broom.helpers to Imports and export tidy_parameters - #313

Closed
shajoezhu with Copilot wants to merge 2 commits into
mainfrom
copilot/add-broom-helpers-to-imports
Closed

Add broom.helpers to Imports and export tidy_parameters#313
shajoezhu with Copilot wants to merge 2 commits into
mainfrom
copilot/add-broom-helpers-to-imports

Conversation

Copilot AI commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

broom.helpers was listed under Suggests, making broom.helpers::tidy_parameters unavailable without a conditional requireNamespace check. This promotes it to a hard dependency so users can rely on it unconditionally.

Changes

  • DESCRIPTION: moved broom.helpers (>= 1.20.0) from SuggestsImports
  • R/crane-package.R: added @importFrom broom.helpers tidy_parameters
  • NAMESPACE: added importFrom(broom.helpers,tidy_parameters)
  • NEWS.md: changelog entry for the change

Copilot AI linked an issue Aug 27, 2026 that may be closed by this pull request
Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
Copilot AI changed the title [WIP] Add broom.helpers to the imports Add broom.helpers to Imports and export tidy_parameters Aug 27, 2026
Copilot AI requested a review from shajoezhu August 27, 2026 14:59
@shajoezhu
shajoezhu marked this pull request as ready for review August 27, 2026 15:01
@github-actions

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                                 Stmts    Miss  Cover    Missing
-------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------
R/add_blank_rows.R                          63       0  100.00%
R/add_difference_row.R                     101       0  100.00%
R/add_forest_utils.R                        97      10  89.69%   76-79, 94-100
R/add_forest.R                             139       0  100.00%
R/add_hierarchical_count_row.R              33       0  100.00%
R/adjust_stat_columns_wrap.R                29       1  96.55%   59
R/annotate_gg_km.R                         141       0  100.00%
R/annotate_gg_pkc.R                        100       0  100.00%
R/annotate_gg.R                             94       0  100.00%
R/ard_tabulate_abnormal_by_baseline.R       65       0  100.00%
R/crane-package.R                            2       2  0.00%    27-28
R/deprecated.R                              21      21  0.00%    18-54
R/df_add_poolings.R                         41       0  100.00%
R/get_cox_pairwise_df.R                    163       0  100.00%
R/gg_km_utils.R                             39      14  64.10%   20-37
R/gg_km.R                                  143      37  74.13%   55-58, 75, 102, 176-181, 184-187, 197-199, 204-205, 239-241, 248-251, 255, 266-270, 283, 285-287
R/gg_lineplot.R                            121       0  100.00%
R/gg_mmrm_lineplot.R                       102       1  99.02%   106
R/gg_pkc_lineplot.R                         98       0  100.00%
R/gg_utils.R                               222       0  100.00%
R/label_roche.R                             72       0  100.00%
R/modify_header_rm_md.R                     18       2  88.89%   35-36
R/modify_split_caption.R                    26       0  100.00%
R/modify_zero_recode.R                      20       1  95.00%   64
R/pk_helper.R                              499       0  100.00%
R/reverse_difference_ci.R                   33       0  100.00%
R/tbl_baseline_chg.R                       188       0  100.00%
R/tbl_coxph.R                               90       1  98.89%   229
R/tbl_hierarchical_incidence_rate.R        291       4  98.63%   430-433
R/tbl_hierarchical_rate_and_count.R        339      13  96.17%   343, 425, 446-456
R/tbl_hierarchical_rate_by_grade.R         317       3  99.05%   169-171
R/tbl_listing.R                             36       0  100.00%
R/tbl_mmrm.R                               344       6  98.26%   452-456, 548
R/tbl_null_report.R                         10       0  100.00%
R/tbl_rmpt.R                               157      12  92.36%   299-304, 316-321
R/tbl_roche_subgroups.R                    157       0  100.00%
R/tbl_roche_summary.R                       64       0  100.00%
R/tbl_shift.R                              116       0  100.00%
R/tbl_survfit_quantiles.R                  154       0  100.00%
R/tbl_survfit_times.R                       92       0  100.00%
R/tbl_with_pools.R                          79       1  98.73%   317
R/theme_gtsummary_roche.R                   87       1  98.85%   61
R/utils.R                                   42       0  100.00%
TOTAL                                     5045     130  97.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: f9799f7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files  308 suites   1m 52s ⏱️
308 tests 308 ✅ 0 💤 0 ❌
895 runs  895 ✅ 0 💤 0 ❌

Results for commit f9799f7.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
annotate_gg_pkc 💚 $2.95$ $-2.47$ annotate_pkc_df_warns_when_given_a_standard_ggplot_object
gg_km 💔 $0.22$ $+2.79$ gg_km_works_and_handles_annotations_correctly

Results for commit 9be0762

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! @Melkiades shall we merge this in

@Melkiades

Copy link
Copy Markdown
Contributor

The issue is that is not used anywhere @shajoezhu and it is only optional in two places. it may be an unnecessary direct dep, right?

@shajoezhu

Copy link
Copy Markdown
Contributor

cool. happy to close this

@shajoezhu shajoezhu closed this Sep 4, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2026
@Melkiades
Melkiades deleted the copilot/add-broom-helpers-to-imports branch September 4, 2026 13:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add broom.helpers to the imports?

3 participants