Closed
Add broom.helpers to Imports and export tidy_parameters#313
Conversation
Co-authored-by: shajoezhu <3692541+shajoezhu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add broom.helpers to the imports
Add broom.helpers to Imports and export tidy_parameters
Aug 27, 2026
shajoezhu
marked this pull request as ready for review
August 27, 2026 15:01
Contributor
Code Coverage SummaryDiff against mainResults for commit: f9799f7 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 308 suites 1m 52s ⏱️ Results for commit f9799f7. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 9be0762 ♻️ This comment has been updated with latest results. |
shajoezhu
approved these changes
Sep 3, 2026
shajoezhu
left a comment
Contributor
There was a problem hiding this comment.
lgtm! @Melkiades shall we merge this in
Contributor
|
The issue is that is not used anywhere @shajoezhu and it is only optional in two places. it may be an unnecessary direct dep, right? |
Contributor
|
cool. happy to close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
broom.helperswas listed underSuggests, makingbroom.helpers::tidy_parametersunavailable without a conditionalrequireNamespacecheck. This promotes it to a hard dependency so users can rely on it unconditionally.Changes
DESCRIPTION: movedbroom.helpers (>= 1.20.0)fromSuggests→ImportsR/crane-package.R: added@importFrom broom.helpers tidy_parametersNAMESPACE: addedimportFrom(broom.helpers,tidy_parameters)NEWS.md: changelog entry for the change