Use file-based store instead of Postgres DB - #25
Closed
sevanspowell wants to merge 9 commits into
Closed
Conversation
Contributor
Author
|
This is still in a DRAFT state, e.g. errors aren't handled properly atm. |
Contributor
Author
|
Artifacts here. Current total memory usage at ~1,048,720,760 bytes, a ~18x decrease from existing levels. |
sevanspowell
force-pushed
the
feature/ADP-869-provide-memory-usage-stats
branch
from
May 18, 2021 04:44
93308e7 to
7753b36
Compare
sevanspowell
force-pushed
the
feature/ADP-869-fix-memory-leak
branch
3 times, most recently
from
May 18, 2021 05:57
eb1d54a to
8c780a5
Compare
- Adds a script that queries the GH repository and sets the state of metadata database to match. - Add NixOS service. - Add integration tests that check that the write part of the script writes correctly, and doesn't touch the database at all if an exception occurs.
sevanspowell
marked this pull request as ready for review
May 19, 2021 01:12
- Add a memory usage NixOS test that provides an overview of metadata-server's memory usage under high load. It doesn't actually "test" anything, only provides statistics.
- Store metadata in the file system instead of a Postgres DB. PR #24 demonstrates that a large user of memory is the Postgres store, specifically building the query for large batch-style requrests. This could be investigated further, but a quick fix is simply to use a file-based store. There is no need to build a query, and files can be looked up quickly using their filename.
sevanspowell
changed the base branch from
feature/ADP-869-provide-memory-usage-stats
to
feature/ADP-895-fix-desync
May 19, 2021 01:34
sevanspowell
force-pushed
the
feature/ADP-869-fix-memory-leak
branch
from
May 19, 2021 01:34
8c780a5 to
bf50f66
Compare
sevanspowell
force-pushed
the
feature/ADP-895-fix-desync
branch
from
May 21, 2021 01:14
68a6f13 to
8ebf937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
demonstrates that a large user of memory is the Postgres store,
specifically building the query for large batch-style requrests. This
could be investigated further, but a quick fix is simply to use a
file-based store. There is no need to build a query, and files can be
looked up quickly using their filename.