Skip to content

Make validateCBOR return Either ValidateCBORError (Evidenced ValidationTrace)#202

Merged
Soupstraw merged 1 commit into
masterfrom
jj/validate-cbor-error
May 15, 2026
Merged

Make validateCBOR return Either ValidateCBORError (Evidenced ValidationTrace)#202
Soupstraw merged 1 commit into
masterfrom
jj/validate-cbor-error

Conversation

@Soupstraw
Copy link
Copy Markdown
Contributor

@Soupstraw Soupstraw commented May 14, 2026

This PR makes validateCBOR return an Either with CBOR errors instead of failing with error.

@Soupstraw Soupstraw changed the title Make validateCBOR return Either Make validateCBOR return Either ValidateCBORError (Evidenced ValidationTrace) May 14, 2026
@Soupstraw Soupstraw requested a review from lehins May 14, 2026 14:41
@Soupstraw Soupstraw force-pushed the jj/validate-cbor-error branch 3 times, most recently from 3eeee38 to 75fbc40 Compare May 14, 2026 14:48
Copy link
Copy Markdown
Contributor

@teodanciu teodanciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment thread src/Codec/CBOR/Cuddle/CBOR/Validator.hs Outdated
Comment thread src/Codec/CBOR/Cuddle/CBOR/Validator.hs
Comment thread src/Codec/CBOR/Cuddle/CBOR/Validator.hs
Comment thread test/Test/Codec/CBOR/Cuddle/CDDL/Validator.hs
Comment thread src/Codec/CBOR/Cuddle/CBOR/Validator.hs Outdated
@Soupstraw Soupstraw force-pushed the jj/validate-cbor-error branch from 16cb7fe to 8c5280d Compare May 15, 2026 10:28
Co-authored-by: teodanciu <teodora.danciu@tweag.io>
@Soupstraw Soupstraw force-pushed the jj/validate-cbor-error branch from 8c5280d to dafa62e Compare May 15, 2026 10:29
@Soupstraw Soupstraw enabled auto-merge May 15, 2026 10:29
@Soupstraw Soupstraw merged commit 93d8c1d into master May 15, 2026
11 checks passed
@Soupstraw Soupstraw deleted the jj/validate-cbor-error branch May 15, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants