Refactor validator to improve error handling#197
Draft
Soupstraw wants to merge 3 commits into
Draft
Conversation
Soupstraw
force-pushed
the
jj/validator-error
branch
9 times, most recently
from
6c3d52f to
2472e2a
Compare
Soupstraw
changed the title
Soupstraw
force-pushed
the
jj/validator-error
branch
3 times, most recently
from
4a5ca40 to
70e647d
Compare
Soupstraw
force-pushed
the
jj/validator-error
branch
from
70e647d to
babc900
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the Validator module to use the
Validatormonad. This lets us get rid of all thecddlpassing anderrorcalls in the code.