fix(pec): do not use reserved machine function from thread catalog#140
Open
emerzn wants to merge 1 commit into
Open
fix(pec): do not use reserved machine function from thread catalog#140emerzn wants to merge 1 commit into
emerzn wants to merge 1 commit into
Conversation
lexelby
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of inkstitch/inkstitch#2668 which references several problems. This PR addresses inkstitch/inkstitch#568 and inkstitch/inkstitch#1105. Due to the color choices in those users' designs, the closest color in the Brother palette were these codes which are meant as applique functions, not an actual color stop.
Besides the usual reference, I manually verified these on my SE700 (and cross-checked my physical manual that the function name is correct):
Meanwhile, every single RGB value in EmbThreadPec.py does not match those in the edutechwiki reference. I used AI to find the 6 biggest differences (pystitch on the left, edutechwiki on the right):
I then tested these pec codes on my SE700 and pystitch (the left) was the clear winner. Not sure why edutechwiki has these wrong, as I believe I read that this library and that resource share the same author.