Open
Conversation
Dependency ReviewThe following issues were found:
License Issues.github/workflows/proto.yml
OpenSSF Scorecard
Scanned Files
|
|
The latest Buf updates on your PR. Results from workflow Protobuf / buf-build (pull_request).
|
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughAdds an npm package section to proto docs and a .gitignore; removes unused imports and reorders one import; adds a comment and formatting refinements in several proto files. No public message/service signatures or runtime behavior changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip You can customize the tone of the review comments and chat replies.Configure the |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
proto/npm/.gitignore (1)
1-5: Consider whether to ignorepackage-lock.json.For published npm packages (as opposed to applications), ignoring the lockfile is a valid choice since consumers will use their own lockfile. However, if you want reproducible builds in CI for the proto generation/publishing workflow, you may want to commit it instead. This is a stylistic choice depending on your workflow preferences.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@proto/npm/.gitignore` around lines 1 - 5, The .gitignore currently excludes package-lock.json; decide whether this repo should track package-lock.json for reproducible CI builds or ignore it because this is a published npm package; then update the .gitignore so package-lock.json is removed from the ignore list if you choose to commit the lockfile (or leave it if you intentionally want consumers to manage locks). Ensure the change addresses the proto generation/publishing workflow by committing package-lock.json when reproducible installs are required, otherwise keep the existing ignore entry for package-lock.json.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@proto/npm/.gitignore`:
- Around line 1-5: The .gitignore currently excludes package-lock.json; decide
whether this repo should track package-lock.json for reproducible CI builds or
ignore it because this is a published npm package; then update the .gitignore so
package-lock.json is removed from the ignore list if you choose to commit the
lockfile (or leave it if you intentionally want consumers to manage locks).
Ensure the change addresses the proto generation/publishing workflow by
committing package-lock.json when reproducible installs are required, otherwise
keep the existing ignore entry for package-lock.json.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 6ed21889-924f-4e3b-a217-bc692d4719b1
⛔ Files ignored due to path filters (4)
.github/workflows/proto.ymlis excluded by!**/*.ymlproto/buf.gen.es.yamlis excluded by!**/*.yamlproto/buf.yamlis excluded by!**/*.yamlproto/npm/package.jsonis excluded by!**/*.json
📒 Files selected for processing (7)
proto/buf.mdproto/ibc/applications/nft_transfer/v1/packet.protoproto/initia/abcipp/mempool/v1/query.protoproto/initia/dynamicfee/v1/query.protoproto/initia/dynamicfee/v1/types.protoproto/initia/reward/v1/tx.protoproto/npm/.gitignore
💤 Files with no reviewable changes (2)
- proto/ibc/applications/nft_transfer/v1/packet.proto
- proto/initia/dynamicfee/v1/query.proto
There was a problem hiding this comment.
🧹 Nitpick comments (1)
proto/npm/.gitignore (1)
4-5: Scope wildcard ignores to generated outputs only.
*.jsand*.d.tsare broad and can accidentally suppress future hand-written files inproto/npm. Prefer narrowing these to known generated paths/patterns.Suggested refinement
-*.js -*.d.ts +# generated outputs only (adjust path/pattern to your generator output layout) +**/*_pb.js +**/*_pb.d.ts🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@proto/npm/.gitignore` around lines 4 - 5, The .gitignore currently uses broad patterns (*.js and *.d.ts) that may hide handwritten files; replace these with targeted ignore entries that match only generated outputs (e.g., generator-specific filenames or directories such as generated JS/TS artifacts or protobuf output like *.pb.js and *.pb.d.ts or a dedicated generated/ or dist/ directory). In the proto/npm/.gitignore update the rules that reference "*.js" and "*.d.ts" to narrowly-scoped patterns matching your generator output (or a generated/ or dist/ directory) so handwritten files in proto/npm are not accidentally ignored while still excluding build artifacts.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@proto/npm/.gitignore`:
- Around line 4-5: The .gitignore currently uses broad patterns (*.js and
*.d.ts) that may hide handwritten files; replace these with targeted ignore
entries that match only generated outputs (e.g., generator-specific filenames or
directories such as generated JS/TS artifacts or protobuf output like *.pb.js
and *.pb.d.ts or a dedicated generated/ or dist/ directory). In the
proto/npm/.gitignore update the rules that reference "*.js" and "*.d.ts" to
narrowly-scoped patterns matching your generator output (or a generated/ or
dist/ directory) so handwritten files in proto/npm are not accidentally ignored
while still excluding build artifacts.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: f431a3eb-0b68-410d-b910-4098c83bb6ee
⛔ Files ignored due to path filters (2)
.github/workflows/proto.ymlis excluded by!**/*.ymlproto/npm/package.jsonis excluded by!**/*.json
📒 Files selected for processing (1)
proto/npm/.gitignore
songwongtp
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
to publish proto definitions on BSR and npmjs.com
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!in the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...