[hackathon] refactor: preparatory generics for host context adapter#104
Open
[hackathon] refactor: preparatory generics for host context adapter#104
Conversation
- Bump SDK deps to 0.16.0-rc.14 and add cargo patch overrides for signet-sdk and storage repos - Make blobber CacheHandle methods generic over receipt type - Adapt blobber shim to BlockAndReceipts struct from SDK - Re-export RecoveredBlockShim from signet-blobber - Simplify ReorgNotification in signet-rpc (remove RemovedBlock, use flat removed_hashes/removed_logs) - Remove filter_reorg_for_sub and stub reorg handling (ENG-1968) - Make AliasOracle::should_alias async via RPITIT - Make block processor process_block/run_evm generic over Extractable Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
prestwich
changed the title
4 tasks
- Remove `should_alias` helper that recreated the oracle per address, restoring the fix from #102 (create oracle once per block) - Revert unrelated rpc/interest changes back to develop Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove cargo patch overrides for signet-storage crates and restore versions to 0.6.5 — these patches are not needed in this PR. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
Explicitly reference the `#[repr(transparent)]` attribute and single-field layout guarantee that makes the reference transmute sound. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
signet-sdk(feat/extractable-metadata) andstorage(james/eng-1978)CacheHandlemethods generic over receipt type and adapt toBlockAndReceiptsstructReorgNotificationin signet-rpc: removeRemovedBlock, flatten toremoved_hashes/removed_logs; stub reorg subscription handling (ENG-1968)AliasOracle::should_aliasasync via RPITITprocess_block/run_evmgeneric overExtractablePR 1 of 5 in the host context adapter refactor. No precursors.
Test plan
cargo clippy -p signet-blobber --all-features --all-targetscargo clippy -p signet-blobber --no-default-features --all-targetscargo clippy -p signet-rpc --all-features --all-targetscargo clippy -p signet-block-processor --all-features --all-targetscargo clippy -p signet-node --all-features --all-targetscargo t -p signet-rpccargo +nightly fmt🤖 Generated with Claude Code