chore: improve debugging/observability#232
Conversation
Fraser999
changed the title
Fraser999
force-pushed
the
fraser/eng-1943/various-updates
branch
from
4235d82 to
52db8c9
Compare
prestwich
left a comment
prestwich
left a comment
There was a problem hiding this comment.
fine with all this. one other note is that builder currently doesn't follow our metrics.rs convention, which is not a big deal but does result in all the metric names being in-line in regular code
| #![recursion_limit = "256"] | ||
|
|
||
| use builder::{ | ||
| config::{BuilderConfig, env_var_info}, |
There was a problem hiding this comment.
cleanliness while we're here, we should consider following the lib+main convention as that should remove the need to add anonymous imports for bin-only deps
src/
|- lib.rs
|- main.rs
There was a problem hiding this comment.
I'll restructure as requested (makes sense to me), but turns out this doesn't affect the clippy warning.
There was a problem hiding this comment.
drat, oh well. let's not restructure then, as that may impact docker setups, etc
|
@prestwich re. your point about the metrics - I created a ticket for this. |
Fraser999
force-pushed
the
fraser/eng-1943/various-updates
branch
2 times, most recently
from
502e395 to
b2a0e39
Compare
Fraser999
force-pushed
the
fraser/eng-1943/various-updates
branch
from
b2a0e39 to
dd232a0
Compare
2 participants
This PR includes several relatively small changes to improve logging, metrics and operator experience. There should be no changes to the core logic, with the exception of changing
BLOCK_QUERY_CUTOFF_BUFFERandSUBMIT_DEADLINE_BUFFERto be optional with defaults where these were previously required vars.NOTE: This depends upon init4tech/bin-base#123