Redraw menu bar icon to match the new Fluent brand#18
Closed
inhaq wants to merge 1 commit into
Closed
Conversation
The menu bar status item was never derived from AppIcon. The idle glyph was the SF Symbol "waveform" (release) or a hand-drawn rounded-square-with-bars (dev), so updating AppIcon-Source.png / AppIcon.icns had no effect on it. Replace StampedMenuBarIcon with FluentMenuBarIcon: a monochrome template glyph that mirrors the new app icon (a speech-bubble ring with a flowing waveform). It is used for the idle state in both release and dev builds, with a small marker dot distinguishing the dev build. Recording/transcribing keep their record.circle / ellipsis.circle status icons. Drawn as a template image so macOS tints it for light/dark menu bars; a full-color icon is not appropriate for a menu bar item.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughMenu bar icon rendering now branches directly on app state for enabled, recording, transcribing, or idle states. The idle icon comes from a new ChangesMenu bar icon rendering
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was created by @kiro-agent on behalf of @inhaq 👻
Comment with /kiro fix to address specific feedback or /kiro all to address everything.
Learn about Kiro Web
Problem
Updating the app icon images (
AppIcon-Source.png/AppIcon.icns) did not change the menu bar icon, because the menu bar status item was never derived from the app icon. InSources/App.swift, the idle glyph was either the SF Symbolwaveform(release build) or a hand-drawn rounded-square-with-bars (StampedMenuBarIcon, dev build).Fix
Replace
StampedMenuBarIconwithFluentMenuBarIcon: a monochrome template glyph that mirrors the new brand — a speech-bubble ring with a flowing waveform inside.record.circle/ellipsis.circlestatus icons.Why a template (monochrome) glyph, not the colorful icon
Menu bar items should be simple monochrome template images so macOS can tint them for light and dark menu bars. The full-color 3D app icon (with its white rounded background) would look wrong in the menu bar, especially in dark mode.
AppIcon.icnsremains the dock/Finder icon.Tested
swiftc -parse Sources/App.swiftpasses. A full build needs the macOS SDK (not available in this Linux sandbox), so please runmake run CODESIGN_IDENTITY=-and confirm the menu bar glyph looks right at 1x/2x in both light and dark menu bars. The bezier coordinates (ring radius, waveform peaks, tail) are easy to nudge if you want the silhouette tweaked.Summary by CodeRabbit
New Features
Bug Fixes