fix: Correctly handle parse errors in html tables#25
Merged
Conversation
The original test data for this feature had invalid HTML (the `<time>` element was not actually in a cell).
When we switched to using masterminds/html5 for table parsing, the parse error detection & handling was not updated. This is partly because there are actually very few cases in which input is actually *invalid* as html (as opposed to being non-conformant, which isn't checked). And we did not have test cases proving these examples. Fixed the handling of this ahead of moving to native html parsing in 1.4 (which is treated differently anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we switched to using masterminds/html5 for table parsing (in #15), the parse error detection & handling was not updated.
This is partly because there are actually very few cases in which input is actually invalid as html (as opposed to being non-conformant, which isn't checked). And we did not have test cases proving these examples.
Fixed the handling of this ahead of moving to native html parsing in 1.4 (which is treated differently anyway).