fix(security): secure OAuth callback redirects - #3984
Draft
thoniTUB wants to merge 2 commits into
Draft
Conversation
Co-authored-by: Codex GPT-5 <codex@openai.com>
awildturtok
reviewed
Aug 27, 2026
awildturtok
left a comment
awildturtok
left a comment
Collaborator
There was a problem hiding this comment.
sieht gut aus aber muss es mir nochmal mit klarerem kopf anschauen
awildturtok
requested changes
Sep 3, 2026
|
|
||
| @JsonIgnore | ||
| @Getter(AccessLevel.NONE) | ||
| private final Cache<String, PendingAuthorizationRequest> pendingAuthorizationRequests = Caffeine.newBuilder() |
Collaborator
There was a problem hiding this comment.
=> CaffeinSpec, und 10K wirkt absurd viel.
| } | ||
|
|
||
| String registerAuthorizationRequest(URI callbackUri, URI returnUri) { | ||
| final String state = UUID.randomUUID().toString(); |
Collaborator
There was a problem hiding this comment.
ist "state" ein oauth name? Meiner intuition nach ist das ja eigentlich ein Identifier?
| } | ||
|
|
||
| static URI toRootRelativeUri(URI requestUri) { | ||
| if (requestUri == null || !requestUri.isAbsolute()) { |
Collaborator
There was a problem hiding this comment.
der null check sollte separat sein imo?
| final JwtPkceVerifyingRealmFactory factory = new JwtPkceVerifyingRealmFactory(); | ||
| final URI callbackUri = URI.create("https://example.com/admin-ui"); | ||
| final String state = factory.registerAuthorizationRequest(callbackUri, URI.create("/admin-ui/users")); | ||
| factory.validateAndConsumeAuthorizationRequest(state, callbackUri); |
Collaborator
There was a problem hiding this comment.
bitte hier kommentar dran machen, dass das stateful ist und ab hier nicht reused werden kann
| ); | ||
| assertThrows( | ||
| BadRequestException.class, | ||
| () -> JwtPkceVerifyingRealmFactory.toRootRelativeUri(URI.create("https://example.com//attacker.example/path")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.