chore: remove support link references #7106
Conversation
wdoconnell
left a comment
wdoconnell
left a comment
There was a problem hiding this comment.
We discussed updates to this in pairing, the gist of which is to do the following (which we will confirm with support):
- Only subject the ability to open the Contact Support modal to a
CLOUDcheck. If the user is not in a PAYG or Contract account, the user will be notified that they are in a free account, and they must log into a paid account (or upgrade) to proceed further. - Encapsulate the logic for the portion of the modal that is conditionally rendered depending on the user's account state into its own components for readability.
- We may (potentially) pipe additional context information (like the organization ID, or general nature of the request -- e.g., 'limit update') into the support modal. We should be able to do that through the Overlay params. Checking with Support on whether they want that (and in what format).
One additional thing to revalidate when this is complete is that everything is still guarded by a CLOUD check, as the modal should only appear in cloud-hosted environments, not OSS.
| <p> | ||
| To request a series cardinality limit increase, please contact our | ||
| support team. | ||
| To request a cardinality limit increase, please use the Contact Support |
There was a problem hiding this comment.
As discussed, to simplify the path for the user here, I think we can actually dispatch an action to open the "contact Support" modal here, with the caveat that the Contact Support modal will need to use a Selector function to determine whether the user is in a Free Account, PAYG Account, or Contract Account. This will simplify the path throughout.
| )} | ||
| /> | ||
| {CLOUD && isContractCustomer && ( | ||
| {CLOUD && (accountType === 'paid' || accountType === 'contract') && ( |
There was a problem hiding this comment.
This will become a CLOUD check only, and the isContractOrPAYG check will occur within the modal
const isContractOrPAYG = accountType === 'paid' || accountType === 'contract'
mnaqvi08
changed the title
mnaqvi08
force-pushed
the
chore/remove-support-link-references
branch
from
4f0eb4b to
3c9857b
Compare
wdoconnell
left a comment
wdoconnell
left a comment
There was a problem hiding this comment.
A few preliminary pointers while we await support review.
| } | ||
|
|
||
| const isFormValid = (): boolean => { | ||
| return !!requestDetails |
There was a problem hiding this comment.
Nit: I would recommend using Boolean(requestDetails) (calling Boolean as a function) over the !! operator. Same behavior, but there is no ability to misread Boolean during a review.
| <AppWrapper type="funnel" className="page-not-found" testID="not-found"> | ||
| <FunnelPage enableGraphic={true} className="page-not-found-funnel"> | ||
| {CLOUD && ( | ||
| const NotFoundNew: FC = () => { |
There was a problem hiding this comment.
It's a little hard to parse this diff. Is this a reversion of the previous commit switching from email?
There was a problem hiding this comment.
This is a combination of integrating the support modal popup and some moving around of tags which is creating a strange diff. It's functionally the same as before.
| testID="contact-support-description--textarea" | ||
| name="description" | ||
| {isContractOrPAYG ? ( | ||
| <> |
There was a problem hiding this comment.
This is what I would recommend, if feasible, putting into its own component to keep this as modular as possible, so we can end up with a simple expression of the conditional render.
{
isContractOrPAYG ? <PaidSupportDisplay /> : <FreeDisplay />
}
|
Closing in favor of #7112. |
Closes #
Checklist
Authors and Reviewer(s), please verify the following: