Skip to content

fix(outputs.parquet): Reserve the timestamp column for the metric time - #19555

Open
81reap wants to merge 2 commits into
influxdata:masterfrom
81reap:parquet-04-reserve-timestamp-column
Open

fix(outputs.parquet): Reserve the timestamp column for the metric time#19555
81reap wants to merge 2 commits into
influxdata:masterfrom
81reap:parquet-04-reserve-timestamp-column

Conversation

@81reap

@81reap 81reap commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Telegraf reserves an int64 timestamp_field_name column for the metric time, but gets conflicting names would carry the same name and two different types. A bad input would go to the int64 builder and panic. (eg :: demo timestamp="x")

Now telegraf drops fields or tags that collide with reserved column names and log the exception.

Checklist

Related issues

resolves # security issue + #19563

@telegraf-tiger telegraf-tiger Bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Aug 26, 2026
@srebhan

srebhan commented Aug 26, 2026

Copy link
Copy Markdown
Member

Can you please base this on master?!

@81reap
81reap force-pushed the parquet-04-reserve-timestamp-column branch from 25296d5 to a6ba84d Compare August 26, 2026 15:41
@81reap
81reap marked this pull request as ready for review August 26, 2026 15:41
@81reap
81reap force-pushed the parquet-04-reserve-timestamp-column branch from a6ba84d to 3a5c434 Compare August 26, 2026 16:08
@81reap

81reap commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

missed the an import in the unit tests so ci failed, fixed now

Telegraf reserves an int64 `timestamp_field_name` column for the metric time, but gets conflicting names would carry the same name and two different types. A bad input would go to the int64 builder and panic. (eg :: `demo timestamp="x"`)

Now telegraf drops fields or tags that collide with reserved column names and log the exception.
@81reap
81reap force-pushed the parquet-04-reserve-timestamp-column branch from 3a5c434 to afb3678 Compare August 26, 2026 18:46

@srebhan srebhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @81reap! I have one suggestion below. Please also fix the markdown linter issue!

Comment thread plugins/outputs/parquet/parquet.go Outdated
@telegraf-tiger

Copy link
Copy Markdown
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 7.28 % for linux amd64 (new size: 330.7 MB, nightly size 308.2 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants