fix(outputs.parquet): Reserve the timestamp column for the metric time - #19555
Open
81reap wants to merge 2 commits into
Open
fix(outputs.parquet): Reserve the timestamp column for the metric time#1955581reap wants to merge 2 commits into
81reap wants to merge 2 commits into
Conversation
Member
|
Can you please base this on master?! |
81reap
force-pushed
the
parquet-04-reserve-timestamp-column
branch
from
August 26, 2026 15:41
25296d5 to
a6ba84d
Compare
81reap
marked this pull request as ready for review
August 26, 2026 15:41
81reap
force-pushed
the
parquet-04-reserve-timestamp-column
branch
from
August 26, 2026 16:08
a6ba84d to
3a5c434
Compare
Contributor
Author
|
missed the an import in the unit tests so ci failed, fixed now |
Telegraf reserves an int64 `timestamp_field_name` column for the metric time, but gets conflicting names would carry the same name and two different types. A bad input would go to the int64 builder and panic. (eg :: `demo timestamp="x"`) Now telegraf drops fields or tags that collide with reserved column names and log the exception.
81reap
force-pushed
the
parquet-04-reserve-timestamp-column
branch
from
August 26, 2026 18:46
3a5c434 to
afb3678
Compare
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telegraf reserves an int64
timestamp_field_namecolumn for the metric time, but gets conflicting names would carry the same name and two different types. A bad input would go to the int64 builder and panic. (eg ::demo timestamp="x")Now telegraf drops fields or tags that collide with reserved column names and log the exception.
Checklist
Related issues
resolves # security issue + #19563