fix(outputs.parquet): Write null instead of panicking on a type mismatch - #19554
Open
81reap wants to merge 1 commit into
Open
fix(outputs.parquet): Write null instead of panicking on a type mismatch#1955481reap wants to merge 1 commit into
81reap wants to merge 1 commit into
Conversation
telegraf-tiger
Bot
added
fix
Member
Parquet files have fixed schemas once created. A value that didn't match the column schema would panic on the output flush goroutine (eg :: (1) `demo k-1i` (2) `demo,k=v other=2i`). Since this is uncaught, it would crash Telegraf. Now values that don't fit the column schema are logged as null and one per column without crashing. The record batch is now also released when the write fails, which previously leaked its arrow buffers.
81reap
force-pushed
the
parquet-03-no-panic-type-mismatch
branch
from
August 26, 2026 18:35
15c1ffc to
8d89f84
Compare
81reap
marked this pull request as ready for review
August 26, 2026 18:35
Member
|
To be honest I would rather drop the metric altogether or start a new file with the alternative scheme. The latter would require that we keep track of the schema of each file and assign the metric to the corresponding file matching the scheme. This would make things more complicated I guess. |
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet files have fixed schemas once created. A value that didn't match the column schema would panic on the output flush goroutine (eg :: (1)
demo k-1i(2)demo,k=v other=2i). Since this is uncaught, it would crash Telegraf.Now values that don't fit the column schema are logged as null and one per column without crashing. The record batch is now also released when the write fails, which previously leaked its arrow buffers.
Checklist
Related issues
resolves # security issue + #19563