influx2otel: Remove runtime dependency on pdatautil - #353
Open
HNO3Miracle wants to merge 1 commit into
Open
Conversation
Collector contrib imports influx2otel from its InfluxDB receiver, while influx2otel imports pdatautil from Collector contrib. This forms a package-level dependency cycle when the repositories are packaged as complete source trees. Use a deterministic, length-delimited attribute key for the two internal lookup maps instead. Keep pdatautil as an indirect test dependency through pdatatest. Signed-off-by: HNO3Miracle <xiangao.or@isrc.iscas.ac.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pdatautil.MapHashcalls with a deterministic, length-delimited attribute keypdatautilonly as an indirect test dependency throughpdatatestMotivation
Collector contrib imports
influx2otelfrom its InfluxDB receiver, whileinflux2otelimportspdatautilfrom Collector contrib. This creates a runtime dependency cycle between the two repositories. The key is used only for internal resource and data-point lookup, so using a deterministic string key removes the cycle without changing the public API.Testing